Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/kubewatch] fix startup issues due to empty resourcesToWatch config #3241

Merged
merged 1 commit into from
Jan 14, 2018
Merged

[incubator/kubewatch] fix startup issues due to empty resourcesToWatch config #3241

merged 1 commit into from
Jan 14, 2018

Conversation

vdboor
Copy link
Contributor

@vdboor vdboor commented Jan 5, 2018

This PR fixes startup issues with the incubator/kubewatch chart. Currently the pod enters in a CrashLoopBackOff because resourcesToWatch is empty. This change provides a sane default configuration and makes it easier to users to discover the various settings for resourcesToWatch.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 5, 2018
@vdboor
[incubator/kubewatch] fix startup issues due to empty resourcesToWatc…
869acb7 
…h config

It also makes the default configuration easier to discover

CC vmware-archive/kubewatch#73
@vdboor vdboor force-pushed the fix/kubewatch-resourcestowatch branch from d56ddbf to 869acb7 Compare January 5, 2018 14:53
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 5, 2018
@vdboor vdboor mentioned this pull request Jan 5, 2018
Open
@compleatang
Copy link

Good catch. LGTM

@unguiculus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 14, 2018
@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: unguiculus, vdboor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit bb824cd into helm:master Jan 14, 2018
@vdboor vdboor deleted the fix/kubewatch-resourcestowatch branch January 14, 2018 21:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@unguiculus unguiculus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vdboor @k8s-ci-robot @compleatang @unguiculus