[Stable/Telegraf] Allow full use of duplicate input/ouputs in telegraf configuration

[amoskyler]

What this PR does / why we need it:
This change converts the inputs and outputs fields from an object with keys associated to configs, to an array of objects which contain keys associated to objects.

Before:

config:
  outputs:
     influxdb:
      ...config...

After:

config:
  outputs:
    - influxdb:
       ...config...

Telegraf supports duplicate same type input and output configurations. In the current chart implementation, each input and output is configured with keys in the objects inputs and outputs respectively. YAML overrides the first key in the object however, and therefore the templating process from YAMl to TOML drops configuration valid TOML configurations, which limits . use of possible valid configurations.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amoskyler
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: scottrigby

Assign the PR to them by writing /assign @scottrigby in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[amoskyler]

CLA signed.

[amoskyler]

/assign @scottrigby

[timstoop]

I'd love to see some documentation in README as well.

[timstoop]

Any reason why you do not make this settable?

[timstoop]

This change adds features, please bump the minor version.

[timstoop]

/ok-to-test

[unguiculus]

cc @jackzampolin

[amoskyler]

I've added some brief documentation for how to add inputs.
I have also updated the documentation in values.yaml to include details on setting updateStrategy.

Unrelated...Why is this chart marked as deprecated? I don't see any alternative charts. The README mentions telegraf-s and telegraf-ds charts, however I can't find them in the charts repo. They do appear to be defined within this chart however, as there are templates for configmap-ds.yaml as well as configmap-s.yaml

[unguiculus]

Deprecated charts are not updated. The chart was deprecated in #823.

See https://github.com/kubernetes/charts/blob/master/PROCESSES.md

Please reach out to the original maintainer @jackzampolin in order to see what can be done.

[amoskyler]

I just went ahead and read that documentation. I didn't read the "deprecated charts are not updated" as an order, but more of implication of the status of deprecation. Why turn down good code?

Do we really need to go through a process where I take over maintenance, make a single PR, and re-deprecate until I'm ready to start the process over again at a later date when I have another PR? (aka, I'm not sure I'm ready to be a maintainer, but I can't contribute to it unless I become the sole maintainer?)

If this project is truly un-maintained, what is the purpose of reaching out to the old maintainer? It would also seem the owner is still listed in the chart, which would seem to be a violation of the deprecation policy.

[amoskyler]

Also, please note the following issue: #3113

This chart was deprecated in favor of two other charts - which appear to be missing.

[unguiculus]

Both of these PRs were closed but you can find them upstream in the InfluxDB repo. I thought it would make sense to ask the maintainer if they still intend to add them here.