Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Typo fix in sonatype-nexus/README.md #4956

Closed
wants to merge 3 commits into from
Closed

Conversation

AdamDang
Copy link
Contributor

In the table's column description:
Sometime first letter in capital, sometime not. It's better use same format.

add version
Typo fix in sonatype-nexus/README.md
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2018
@AdamDang
Copy link
Contributor Author

/assign @unguiculus

@rjkernick
Copy link
Collaborator

/assign

@rjkernick
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AdamDang, rjkernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2018
@rjkernick
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 15, 2018
@rjkernick
Copy link
Collaborator

Please increment your version in Chart.yaml

@AdamDang AdamDang changed the title Typo fix in sonatype-nexus/README.md Typo fix for sonatype-nexus/README.md Apr 15, 2018
@AdamDang
Copy link
Contributor Author

/test pull-charts-e2e

@rjkernick
Copy link
Collaborator

The test is failing due to the version needing bumped further.

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2018
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@AdamDang
Copy link
Contributor Author

Thanks! @rjkernick
After I committed this PR, some other PR changed the version as same as I modified.
Now It's OK.

@AdamDang AdamDang changed the title Typo fix for sonatype-nexus/README.md Typo fix in sonatype-nexus/README.md Apr 15, 2018
@AdamDang
Copy link
Contributor Author

/retest

@rjkernick
Copy link
Collaborator

Having the same issue on this pull request. Please rebase off of master. https://help.github.com/articles/syncing-a-fork/

@k8s-ci-robot
Copy link
Contributor

@AdamDang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-charts-e2e 08a104d link /test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@AdamDang
Copy link
Contributor Author

@rjkernick This PR is recreated on #5042.
Thanks!

@AdamDang AdamDang closed this Apr 15, 2018
@AdamDang AdamDang deleted the patch-151 branch May 1, 2018 02:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants