This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/concourse] Expose prometheus port in web service #6338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
richardalberto
changed the title
richardalberto
force-pushed
the
concourse-expose-prometheus-port
branch
from
3d3f72e
to
610892a
Compare
richardalberto
force-pushed
the
concourse-expose-prometheus-port
branch
from
2a350da
to
e9dc43a
Compare
|
+1 based on the discussion in #6422 (comment) |
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
@richardalberto you'll also need to bump the chart version, please bump the minor version. |
richardalberto
force-pushed
the
concourse-expose-prometheus-port
branch
from
e9dc43a
to
54faae3
Compare
richardalberto
force-pushed
the
concourse-expose-prometheus-port
branch
from
54faae3
to
587cda5
Compare
|
@william-tran ready to merge. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardalberto, william-tran The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thanks @richardalberto @2color ! |
aba182
pushed a commit
to aba182/charts
that referenced
this pull request
Sep 7, 2018
Signed-off-by: aba182 <ajwilhel@gmail.com>
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
Signed-off-by: Jakob Niggel <info@jakobniggel.de>
gsemet
pushed a commit
to gsemet/charts
that referenced
this pull request
Nov 13, 2018
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR exposes the prometheus port (if enabled) on the concourse web service. This enables users of the prometheus operator to create ServiceMonitor definitions to monitor concourse deployments.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: