Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/artifactory-ha] Bumping up version to 6.2.0 #7320

Merged
merged 4 commits into from
Aug 27, 2018
Merged

[stable/artifactory-ha] Bumping up version to 6.2.0 #7320

merged 4 commits into from
Aug 27, 2018

Conversation

jainishshah17
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 23, 2018
@rimusz
Copy link
Contributor

rimusz commented Aug 23, 2018

you forgot to bump chart version

@rimusz
Copy link
Contributor

rimusz commented Aug 23, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 23, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2018
@rimusz
Copy link
Contributor

rimusz commented Aug 23, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2018
@jainishshah17
Copy link
Contributor Author

/retest

@jainishshah17
Copy link
Contributor Author

/test pull-charts-e2e

@k8s-ci-robot
Copy link
Contributor

@jainishshah17: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@jainishshah17: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-charts-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jainishshah17
Copy link
Contributor Author

@rimusz I think its failing because of low resources. Is there any way to bump up node resources and retest?

@rimusz
Copy link
Contributor

rimusz commented Aug 27, 2018

I do not have access to infra, maybe @mattfarina or @unguiculus can answer the question about recourses

@rimusz
Copy link
Contributor

rimusz commented Aug 27, 2018

ok, I was able to reproduce the issue with charts-testing chart_test.sh script:

$ helm ls
artifactory-ha-7219pws7otxtcr6g
$ kubectl describe -n artifactory-ha-dmn0miwywb4tcegj statefulset
...
  Warning  FailedCreate      3m (x25 over 8m)  statefulset-controller  create Pod artifactory-ha-dmn0miwywb4tcegj-artifactory-ha-member-0 in StatefulSet artifactory-ha-dmn0miwywb4tcegj-artifactory-ha-member failed error: Pod "artifactory-ha-dmn0miwywb4tcegj-artifactory-ha-member-0" is invalid: metadata.labels: Invalid value: "artifactory-ha-dmn0miwywb4tcegj-artifactory-ha-member-545fd89668": must be no more than 63 characters
...

the release names generated with chart_test.sh are too long for statefullsets.

@rimusz rimusz mentioned this pull request Aug 27, 2018
Closed
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2018
@rimusz
Copy link
Contributor

rimusz commented Aug 27, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jainishshah17, rimusz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattfarina mattfarina added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 27, 2018
@jainishshah17 jainishshah17 mentioned this pull request Aug 27, 2018
Merged
@davidkarlsen
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 27, 2018
@k8s-ci-robot k8s-ci-robot merged commit 7e181e9 into helm:master Aug 27, 2018
@rimusz rimusz mentioned this pull request Aug 28, 2018
Merged
rimusz added a commit to rimusz/chart-testing that referenced this pull request Aug 28, 2018
@rimusz
Limits release name to 29 characters.
cabebec 
Fixes an issue helm/charts#7320 (comment)
rimusz added a commit to rimusz/chart-testing that referenced this pull request Aug 28, 2018
@rimusz
Limits release name to 29 characters.
5156122 
Fixes an issue helm/charts#7320 (comment)

Signed-off-by: rimas <rmocius@gmail.com>
mattfarina pushed a commit to helm/chart-testing that referenced this pull request Aug 29, 2018
@rimusz @mattfarina
[fix]: Limits release name to 29 characters. (#14)
64c0eef 
* Limits release name to 29 characters.
Fixes an issue helm/charts#7320 (comment)

Signed-off-by: rimas <rmocius@gmail.com>

* fix linting errors

Signed-off-by: rimas <rmocius@gmail.com>

* fix linting errors

Signed-off-by: rimas <rmocius@gmail.com>

* cut random_suffix to 10 long

Signed-off-by: rimas <rmocius@gmail.com>

* cut release name to 10 long

Signed-off-by: rimas <rmocius@gmail.com>
ishabalin pushed a commit to NinthDecimal/charts that referenced this pull request Sep 3, 2018
@jainishshah17
[stable/artifactory-ha] Bumping up version to 6.2.0 (helm#7320)
30b4222 
* upgrading Artifactory version

* bumping chart version

* changing source repo

* truncating long release names

Signed-off-by: ishabalin <ishabalin@ninthdecimal.com>
marekaf pushed a commit to marekaf/charts that referenced this pull request Sep 4, 2018
@jainishshah17 @marekaf
[stable/artifactory-ha] Bumping up version to 6.2.0 (helm#7320)
df59862 
* upgrading Artifactory version

* bumping chart version

* changing source repo

* truncating long release names

Signed-off-by: Marek Bartik <mab@revolgy.com>
Signed-off-by: Marek Bartik <bartimar6@gmail.com>
aba182 pushed a commit to aba182/charts that referenced this pull request Sep 7, 2018
@jainishshah17 @aba182
[stable/artifactory-ha] Bumping up version to 6.2.0 (helm#7320)
e16a869 
* upgrading Artifactory version

* bumping chart version

* changing source repo

* truncating long release names

Signed-off-by: aba182 <ajwilhel@gmail.com>
aba182 pushed a commit to aba182/charts that referenced this pull request Sep 7, 2018
@jainishshah17 @aba182
[stable/artifactory-ha] Bumping up version to 6.2.0 (helm#7320)
18f9c0d 
* upgrading Artifactory version

* bumping chart version

* changing source repo

* truncating long release names

Signed-off-by: aba182 <ajwilhel@gmail.com>
jicowan pushed a commit to jicowan/charts that referenced this pull request Oct 2, 2018
@jainishshah17 @jicowan
[stable/artifactory-ha] Bumping up version to 6.2.0 (helm#7320)
a14f31c 
* upgrading Artifactory version

* bumping chart version

* changing source repo

* truncating long release names

Signed-off-by: jenkin-x <jicowan@hotmail.com>
Jnig pushed a commit to Jnig/charts that referenced this pull request Nov 13, 2018
@jainishshah17 @Jnig
[stable/artifactory-ha] Bumping up version to 6.2.0 (helm#7320)
b44fdc1 
* upgrading Artifactory version

* bumping chart version

* changing source repo

* truncating long release names

Signed-off-by: Jakob Niggel <info@jakobniggel.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rimusz rimusz rimusz approved these changes

@scottrigby scottrigby Awaiting requested review from scottrigby

Assignees

@rimusz rimusz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jainishshah17 @rimusz @k8s-ci-robot @davidkarlsen @mattfarina