[stable/gocd] Easier GoCD agent-only (no server).

[MPV]

What this PR does / why we need it:
This change can be helpful if you'd like to use this chart for "agent only" deployment.

For example if you'd like to reuse long-running GoCD agents instead of letting the Elastic Agents plugin create a new agent for each job, as per gocd/kubernetes-elastic-agents#53.

To disable the GoCD server of this chart, this is what you needed to do before this change:

server:
  enabled: false
  ingress:
    enabled: false
  persistence:
    enabled: false

...and after:

server:
  enabled: false

Special notes for your reviewer:
Open to feedback if you think this makes sense.

[MPV]

(I haven't updated the CHANGELOG.md or bumped the chart version yet, but I'll do that if you think this change makes sense in general)

[MPV]

/assign @varshavaradarajan

[GaneshSPatil]

@MPV -- Thanks for the PR. I understand your point.
Agent Only deployment should be implicit and should not create any server related k8s resources if server.enabled is false. Rather than setting multiple flags for no-server deployment, it should use just one server.enabled flag.

[GaneshSPatil]

@MPV - The lint is failing for bump-up chart version.
can you bump up the chart version and update the changelog?

[GaneshSPatil]

can you bump up the chart version and update the changelog?

[MPV]

@GaneshSPatil Chart version and changelog bumped.

I don't see the changes in the pull request yet though, but maybe it'll arrive soon, as I see them in my fork branch: master...MPV:gocd-server-enabled

[MPV]

/retest

[k8s-ci-robot]

@MPV: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MPV]

Would you like to trigger tests @GaneshSPatil ? 😊

[GaneshSPatil]

@MPV -- The circleci lint is failing for bump up chart version. I can see that you've updated changelog file, but I don't see any changes in the Chart.yaml file.
Would you mind bumping up the chart version in Chart.yaml too ?

[GaneshSPatil]

/assign @maheshp

[k8s-ci-robot]

@GaneshSPatil: GitHub didn't allow me to assign the following users: maheshp.

Note that only helm members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @maheshp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MPV]

@GaneshSPatil @maheshp Mea culpa. Now the Chart.yaml is bumped too. ✅
It got lost in the merge before, but it's added again now.

[GaneshSPatil]

/ok-to-test

[MPV]

Tests green ✅

Just needs LGTM / approved labels, if you agree @GaneshSPatil @varshavaradarajan ?

[davidkarlsen]

/lgtm

[davidkarlsen]

/approve

[GaneshSPatil]

/approve /lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, GaneshSPatil, MPV

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/gocd/OWNERS [GaneshSPatil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[GaneshSPatil]

@MPV -- Thanks again for the contribution!

[MPV]

Thanks all involved for your help. ❤️