Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus] Add cluster.advertise-address to alertmanager cmd args #8562

Merged
merged 2 commits into from
Oct 24, 2018
Merged

[stable/prometheus] Add cluster.advertise-address to alertmanager cmd args #8562

merged 2 commits into from
Oct 24, 2018

Conversation

kirrmann
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Oct 17, 2018
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 17, 2018
@gianrubio
Copy link
Collaborator

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. lgtm Indicates that a PR is ready to be merged. labels Oct 23, 2018
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Oct 24, 2018
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2018
@kirrmann
Copy link
Contributor Author

/retest

@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2018
@kirrmann
[stable/prometheus] Add cluster.advertise-address to alertmanager cmd…
128e3f2 
… args

Signed-off-by: Stefan Kirrmann <stefan.kirrmann@gmail.com>
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2018
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2018
@kirrmann
Copy link
Contributor Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@kirrmann: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gianrubio
Copy link
Collaborator

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gianrubio, kirrmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2b7cc7f into helm:master Oct 24, 2018
Jnig pushed a commit to Jnig/charts that referenced this pull request Nov 13, 2018
@kirrmann @Jnig
[stable/prometheus] Add cluster.advertise-address to alertmanager cmd…
37c5e28 
… args (helm#8562)

Signed-off-by: Stefan Kirrmann <stefan.kirrmann@gmail.com>
Signed-off-by: Jakob Niggel <info@jakobniggel.de>
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
@kirrmann @wgiddens
[stable/prometheus] Add cluster.advertise-address to alertmanager cmd…
b93eb39 
… args (helm#8562)

Signed-off-by: Stefan Kirrmann <stefan.kirrmann@gmail.com>
@sshishov sshishov mentioned this pull request May 2, 2020
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gianrubio gianrubio Awaiting requested review from gianrubio

@mgoodness mgoodness Awaiting requested review from mgoodness

Assignees

@gianrubio gianrubio

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kirrmann @gianrubio @k8s-ci-robot @helm-bot