-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Map.yaml) : added new map for hpa apiversion autoscaling/v2beta2 #126
Conversation
The current version of plugin does not update hpa release manifest when it contains apiVersion autoscaling/v2beta2, it only works for autoscaling/v2beta1. hence i added one more mapping Signed-off-by: Ramdas Potale <30315028+ramdaspotale@users.noreply.github.com>
pinging @mattfarina for approval |
sorry for pinging individually as this changes is pending since March...and are causing issues with plugin |
Sending my approval of this PR as a bump, Posting in case anybody isn't aware,
It's such a simple change and would also really appreciate if this got merged sooner rather than later |
Thanks @soony88 for the bump, also for sharing the workaround although already i have build plugin with updated map file as workaround. |
Please merge asap. We really need this feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already tested with success:
+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is covered in another PR.
Thanks for the PR. Multiple PRs came in to address this and another one has already been merged. Closing this one. |
The current version of plugin does not update hpa release manifest when it contains apiVersion autoscaling/v2beta2, it only works for autoscaling/v2beta1. hence i added one more mapping