Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Map.yaml) : added new map for hpa apiversion autoscaling/v2beta2 #126

Closed
wants to merge 1 commit into from

Conversation

ramdaspotale
Copy link

The current version of plugin does not update hpa release manifest when it contains apiVersion autoscaling/v2beta2, it only works for autoscaling/v2beta1. hence i added one more mapping

The current version of plugin does not update hpa release manifest when it contains apiVersion autoscaling/v2beta2, it only works for autoscaling/v2beta1. hence i added one more mapping 

Signed-off-by: Ramdas Potale <30315028+ramdaspotale@users.noreply.github.com>
@ramdaspotale
Copy link
Author

pinging @mattfarina for approval

@ramdaspotale
Copy link
Author

@hickeyma

@ramdaspotale
Copy link
Author

sorry for pinging individually as this changes is pending since March...and are causing issues with plugin

@skhtor
Copy link

skhtor commented Oct 11, 2023

Sending my approval of this PR as a bump,

Posting in case anybody isn't aware,
As a workaround, you can copy the Map.yaml in this repo (along with the added HPA mapping) and save it as a local file to reference when running the binary with the following flag.

--mapfile string           path to the API mapping file (default "config/Map.yaml")

It's such a simple change and would also really appreciate if this got merged sooner rather than later

@ramdaspotale
Copy link
Author

ramdaspotale commented Oct 12, 2023

Thanks @soony88 for the bump, also for sharing the workaround although already i have build plugin with updated map file as workaround.

@multhamb
Copy link

multhamb commented Feb 6, 2024

Please merge asap. We really need this feature

Copy link

@multhamb multhamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already tested with success:

@manny-semc
Copy link

+1

Copy link
Contributor

@robertsirc robertsirc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is covered in another PR.

@mattfarina
Copy link
Contributor

Thanks for the PR. Multiple PRs came in to address this and another one has already been merged. Closing this one.

@mattfarina mattfarina closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants