Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript errors on version 4.3.0 #283

Closed
beetlebum opened this issue Dec 27, 2020 · 5 comments
Closed

Typescript errors on version 4.3.0 #283

beetlebum opened this issue Dec 27, 2020 · 5 comments

Comments

@beetlebum
Copy link

Two new errors have appeared on the typescript definitions after upgrading to 4.3.0:

node_modules/helmet/dist/middlewares/content-security-policy/index.d.ts:21:70 - error TS1335: 'unique symbol' types are not allowed here.

21         [x: string]: Iterable<ContentSecurityPolicyDirectiveValue> | unique symbol;
                                                                        ~~~~~~~~~~~~~

node_modules/helmet/dist/middlewares/content-security-policy/index.d.ts:23:9 - error TS1332: A variable whose type is a 'unique symbol' type must be 'const'.

23     var dangerouslyDisableDefaultSrc: unique symbol;
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@EvanHahn
Copy link
Member

EvanHahn commented Dec 27, 2020 via email

@beetlebum
Copy link
Author

^4.1.3

@EvanHahn
Copy link
Member

Ah, I'm now seeing the error. I'll push up a fix soon, likely v4.3.1.

EvanHahn added a commit that referenced this issue Dec 27, 2020
This fixes a TypeScript error reported in [#283][283].

[283]: #283
@EvanHahn
Copy link
Member

I just opened #284 which should fix this issue. I'll let you know when I release it.

EvanHahn added a commit that referenced this issue Dec 27, 2020
This fixes a TypeScript error reported in [#283][283].

[283]: #283
@EvanHahn
Copy link
Member

This should be fixed in helmet@4.3.1. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants