Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

Change the behavior when options.maxAge == null #26

Closed
EvanHahn opened this issue Jun 10, 2019 · 1 comment
Closed

Change the behavior when options.maxAge == null #26

EvanHahn opened this issue Jun 10, 2019 · 1 comment
Assignees
@EvanHahn
Labels
in progress

Comments

@EvanHahn
Copy link
Member

Currently, these are equivalent:

hsts({})
hsts({maxAge: null})
hsts({maxAge: undefined})

They shouldn't be—supplying the parameter (at all, even as a nil value) should be considered invalid.
@EvanHahn EvanHahn mentioned this issue Jun 10, 2019
Merged
@EvanHahn EvanHahn self-assigned this Sep 1, 2019
EvanHahn added a commit that referenced this issue Sep 1, 2019
@EvanHahn
Drop support for Node <8; change maxAge: null behavior; remove deprec…
2cb4cc5 
…ated options

Closes #21.
Closes #22.
Closes #26.
@EvanHahn
Copy link
Member Author

EvanHahn commented Sep 1, 2019

This will be deployed in hsts@3. Follow #29 for progress there.

@EvanHahn EvanHahn closed this as completed Sep 1, 2019
EvanHahn added a commit that referenced this issue Apr 12, 2020
@EvanHahn
Drop support for Node <8; change maxAge: null behavior; remove deprec…
9323213 
…ated options

Closes #21.
Closes #22.
Closes #26.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EvanHahn EvanHahn

Labels
in progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EvanHahn