logical and bitwise functions #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
==========================================
- Coverage 96.68% 96.65% -0.03%
==========================================
Files 57 57
Lines 12142 12107 -35
==========================================
- Hits 11739 11702 -37
- Misses 403 405 +2
Continue to review full report at Codecov.
|
|
@mtar i am going to need you to merge the master with this one. you know this code better than i |
coquelin77
requested changes
Dec 18, 2019
heat/core/tests/test_arithmetics.py
Outdated
| @@ -276,6 +255,32 @@ def test_fmod(self): | |||
| with self.assertRaises(TypeError): | |||
| ht.fmod("T", "s") | |||
|
|
|||
| def test_invert(self): | |||
| int_tensor = ht.array([[0, 1], [2, -2]]) | |||
There was a problem hiding this comment.
can you add one test to all of these with a different int datatype? i.e. int16 or something like that
…lytics/heat into features/bitwiselogicalops
coquelin77
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #225 #226, improves #366
Changes proposed:
Type of change
[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
Are all split configurations tested and accounted for?
[x] yes [ ] no
Does this change require a documentation update outside of the changes proposed?
[ ] yes [x] no
Does this change modify the behaviour of other functions?
[ ] yes [x] no
Are there code practices which require justification?
[ ] yes [x] no