Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/798 logical dndarrray #851

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Jul 29, 2021

Description

replaced factories.array in isclose, kept in sanitize_input_type

Issue/s resolved: #798

Changes proposed:

  • isclose: factories.array -> DNDarray

Type of change

  • enhancement/performance/improvement

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@mtar mtar requested a review from ClaudiaComito July 29, 2021 13:36
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #851 (a89c2ca) into master (50a743a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #851   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files          64       64           
  Lines        9130     9130           
=======================================
  Hits         8706     8706           
  Misses        424      424           
Flag Coverage Δ
gpu 94.50% <100.00%> (ø)
unit 91.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/logical.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a743a...a89c2ca. Read the comment docs.

Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @mtar!

@ClaudiaComito ClaudiaComito merged commit 86413ff into master Aug 18, 2021
@ClaudiaComito ClaudiaComito deleted the enhancement/798-logical-dndarrray branch August 18, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module logical: replace factories.array() with DNDarray construct where possible
3 participants