Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/529 lasso example #876

Merged
merged 6 commits into from
Oct 8, 2021
Merged

Bugfix/529 lasso example #876

merged 6 commits into from
Oct 8, 2021

Conversation

bhagemeier
Copy link
Member

@bhagemeier bhagemeier commented Oct 4, 2021

Description

Make examples work. The code examples in the examples folder were not fully aligned with some changes, e.g. paths to example data and Python path setup. Additionally, at least the Lasso example requires matplotlib and scikit-learn, which can now be pulled in as optional dependencies.

Issue/s resolved: #529

Changes proposed:

  • path adaptation (Lasso and KNN examples)
  • optional dependencies to run examples

Type of change

  • Bug fix

Due Diligence

Only example code has been modified.

Does this change modify the behaviour of other functions? If so, which?

no

- prepend path to heat sources
- fix path to diabetes dataset

Fixes #529
- scikit-learn 0.24.0 tested as sufficient
- matplotlib 3.1.0 tested as sufficient
@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #876 (b9510bb) into master (d853605) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #876   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files          64       64           
  Lines        9459     9459           
=======================================
  Hits         9032     9032           
  Misses        427      427           
Flag Coverage Δ
gpu 94.61% <ø> (ø)
unit 91.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d853605...b9510bb. Read the comment docs.

@bhagemeier bhagemeier marked this pull request as ready for review October 5, 2021 10:57
@coquelin77 coquelin77 merged commit 7907a5a into master Oct 8, 2021
@coquelin77 coquelin77 deleted the bugfix/529-lasso-example branch October 8, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up Lasso file, make examples work
2 participants