Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Chained className unique hashing #11

Merged
merged 1 commit into from
May 7, 2018
Merged

Fix: Chained className unique hashing #11

merged 1 commit into from
May 7, 2018

Conversation

ItsJonQ
Copy link
Contributor

@ItsJonQ ItsJonQ commented May 7, 2018

Fix: Chained className unique hashing

This update fixes the unique hashing for chained classNames like:

.Card.is-big

Which should resolve to:

.Card__j1hdj1-1.is-big

Resolves: #10

Fix: Chained className unique hashing
115cf4b 
This update fixes the unique hashing for chained classNames like:

```
.Card.is-big
```

Which should resolve to:

```
.Card__j1hdj1-1.is-big
```
@ItsJonQ ItsJonQ added the bug Something isn't working label May 7, 2018
@ItsJonQ ItsJonQ self-assigned this May 7, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 52

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 49: 0.0%
Covered Lines: 121
Relevant Lines: 121
💛 - Coveralls

@ItsJonQ ItsJonQ merged commit fd856ae into master May 7, 2018
@ItsJonQ ItsJonQ deleted the fix-chained-classnames branch May 8, 2018 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ItsJonQ ItsJonQ

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unique hash should be added to first className only
2 participants
@ItsJonQ @coveralls