Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Combinator rules with mixed base names #12

Merged
merged 1 commit into from
May 7, 2018

Conversation

ItsJonQ
Copy link
Contributor

@ItsJonQ ItsJonQ commented May 7, 2018

Fix: Combinator rules with mixed base names 🍃

This update allows for the unique hashing to correctly handle combinator-based
rules with different basenames.

For example, this rule:

.First + .Second

Now correctly compiles to:

.First__b123lhjd-1 + .Second

This update allows for the unique hashing to correctly handle combinator-based
rules with different basenames.

For example, this rule:

```
.First + .Second
```

Now correctly compiles to:

```
.First__b123lhjd-1 + .Second
```
@ItsJonQ ItsJonQ added bug Something isn't working enhancement New feature or request labels May 7, 2018
@ItsJonQ ItsJonQ self-assigned this May 7, 2018
@ItsJonQ ItsJonQ merged commit 0d5e87f into master May 7, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 57

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 54: 0.0%
Covered Lines: 130
Relevant Lines: 130

💛 - Coveralls

@ItsJonQ ItsJonQ deleted the fix-combinator-mix-base branch May 8, 2018 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants