Scope: CSS Extend fix #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 12, 2018 21:42
This update fixes the styled(Component) extending functionality with Emotion. The issue was that the cssWithScope function was comparing the SCOPED namespace rather than the CSS selector. This wasn't compatible with Emotion's cache consolidator, which resulted in scoped classes NOT being able to be extended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope: CSS Extend fix
This update fixes the styled(Component) extending functionality with Emotion.
The issue was that the cssWithScope function was comparing the SCOPED namespace
rather than the CSS selector. This wasn't compatible with Emotion's
cache consolidator, which resulted in scoped classes NOT being able to be
extended.
Some very crude tests.
Before:
After:
Notice how in the After pic, both lines only have 2 classes, whereas the Before pic, it was 2 and 3.
Resolves: #27