PureComponents, by default #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update adjusts the create-emotion-styled HOC to create
React.PureComponent styled components, by default. This is for an
overall performance boost, as PureComponent classes perform faster
than default Component classes.
This should be safe, as we've been using PureComponents exclusively,
at the library level, for a while now. Not to mention, React Redux
also defaults to PureComponents.
This behaviour can be customized by defining `{ pure: false }` in a
new argument for `create-emotion-styled`.
ItsJonQ
commented
Dec 3, 2018
| @@ -1,7 +1,6 @@ | |||
| { | |||
| "recommendations": [ | |||
| "dbaeumer.vscode-eslint", | |||
| "flowtype.flow-for-vscode", | |||
There was a problem hiding this comment.
Going to (eventually) replace Flow with TS.
This will probably happen during the Emotion 9 -> 10 migration
ItsJonQ
commented
Dec 3, 2018
| @@ -85,7 +96,9 @@ function createEmotionStyled(emotion: Object, view: ReactType) { | |||
| } | |||
| } | |||
|
|
|||
| class Styled extends view.Component<*, {theme: Object}> { | |||
| const OuterBaseComponent = pure ? view.PureComponent : view.Component | |||
There was a problem hiding this comment.
Pattern established in wedux (inspired by react-redux)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PureComponents, by default
This update adjusts the create-emotion-styled HOC to create
React.PureComponent styled components, by default. This is for an
overall performance boost, as PureComponent classes perform faster
than default Component classes.
This should be safe, as we've been using PureComponents exclusively,
at the library level, for a while now. Not to mention, React Redux
also defaults to PureComponents.
This behaviour can be customized by defining
{ pure: false }in anew argument for
create-emotion-styled.