Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Fixes inserting empty return if there is no value in field #464

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Fixes inserting empty return if there is no value in field #464

merged 1 commit into from
Jan 31, 2019

Conversation

tjbo
Copy link
Contributor

@tjbo tjbo commented Jan 31, 2019 •
edited by ItsJonQ
Loading

Fixes inserting empty return if there is no value in field

This update fixes empty carriage return insertions when there is no pre-existing value in the field.

@tjbo tjbo requested a review from ItsJonQ January 31, 2019 20:35
@tjbo
Copy link
Contributor Author

tjbo commented Jan 31, 2019

HSDS: Fix empty return if no value

ItsJonQ
ItsJonQ approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@ItsJonQ ItsJonQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 from me! Tests look good. Tested manually on Netlify. Works as expected!

Enter only works after a value has been added.

@ItsJonQ ItsJonQ merged commit 3b15148 into master Jan 31, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1574

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 99.989%
Totals Coverage Status
Change from base Build 1572: -0.01%
Covered Lines: 6089
Relevant Lines: 6089
💛 - Coveralls

@ItsJonQ ItsJonQ deleted the fix-empty-return-insertion branch April 2, 2019 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ItsJonQ ItsJonQ ItsJonQ approved these changes

Assignees

@tjbo tjbo

Labels
enhancement ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjbo @coveralls @ItsJonQ