You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wrote the same code yesterday and irrc this doesn't filter out ignored files - rather you need to do `Some(Default::default())`. Did you test this?
Likewise - why does this matter to buffrs? Surely for buffrs there are like 2 files that matter and who cares if the user has a bunch of other files edited - that's not buffrs' purpose. Surely it should only care about buffrs files?
And some tool which manages overall CI should care about dirtiness? It's actually very common for publish scripts to end up with a dirty repo with both Rust and Python when using git versions, because you have to write the versions into the packages.
This discussion was converted from issue #61 on October 10, 2023 13:33.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Likewise - why does this matter to buffrs? Surely for buffrs there are like 2 files that matter and who cares if the user has a bunch of other files edited - that's not buffrs' purpose. Surely it should only care about buffrs files?
And some tool which manages overall CI should care about dirtiness? It's actually very common for publish scripts to end up with a dirty repo with both Rust and Python when using git versions, because you have to write the versions into the packages.
Originally posted by @j-baker in #38 (comment)
Beta Was this translation helpful? Give feedback.
All reactions