Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0/bug/filters noshow #136

Merged
merged 4 commits into from
Aug 2, 2022
Merged

Conversation

mikael-stromgren
Copy link
Contributor

  • Local react files instead of CDN
  • Several errors in Gutenberg fixed
  • Filter functionality restored
  • Design fixes (dependant of classes added in hbg-react)

@mikael-stromgren mikael-stromgren changed the base branch from master to 3.0/develop July 1, 2022 14:46
Copy link
Contributor

@faejr faejr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but I've never worked with this part so I'm not entirely sure.

Other than the comments I wonder if it's possible to enqueue react without keeping these huge react files in the repo? Could we get them with npm or something instead?

source/php/Helper/React.php Outdated Show resolved Hide resolved
@mikael-stromgren mikael-stromgren merged commit eb19561 into 3.0/develop Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants