Add reconnect logic #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daenney
reviewed
Jan 2, 2020
| @@ -142,24 +147,29 @@ func (m *mqtt) init(ctx context.Context, client mqttClient) (err error) { | |||
| return | |||
| } | |||
|
|
|||
| func (m *mqtt) onConnect(server string, code byte, err error) { | |||
| func (m *mqtt) onConnect(server string, _code byte, err error) { | |||
There was a problem hiding this comment.
This feels a little weird. The _ thing isn't something we normally do in Go, and if all we're going to do is transform it into a Code, why not accept a Code to begin with?
There was a problem hiding this comment.
The signature has to match libmqtt.ConnHandler:
type ConnHandler func(server string, code byte, err error)
I could name it something else, like rawCode instead
|
Fixing issue #12 instead of implementing reconnect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added reconnect logic and better error messages on MQTT errors