-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make cache key timestamping optional. #126
Conversation
We have the same problem! Having this option might help us a lot @hendrikmuhs |
Looks good to me, instead of |
Thanks! I can merge and fix the js files myself. The last dependabot updates broke the build anyway. |
Nice!! thanks a lot @hendrikmuhs, @fruffy |
I was eager to try this as I also don't like having one cache for each of the runs, but it seems that this doesn't actually work, as saving the cache always fails when using the new option and the cache already exists. According to this comment, an existing cache can't be overwritten, and if this is correct, then the new option is not very useful. Or am I missing something here? |
Part of the motivation for this PR was to get some control over the key signature. You can still define a key that is flexible enough to avoid that issue (using PR/commit IDs). This is what we have been doing. But yes, it is an issue right now. Hope they will fix that bug at some point. |
Thanks for the clarification, it wasn't obvious that using this option required making the key unique in some other way. I think it would be nice to mention this in the README. |
Prompted by #117.
For Github repositories with many different actions and concurrent PRs,
ccache-action
's timestamps can quickly fill up the cache and evict other cached entries. This PR adds an option to disable timestamping.I am not familiar with either Javascript or Github Actions, so suggestions on how to improve this are very much welcome.