Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a story is loaded from JSON, it currently does not convert the action IDs to ints. It looks like Kobold prevents this from causing issues by refreshing the page, but in Ghostpad I've noticed catastrophic bugs resulting from it.
First a story is loaded and string-based IDs get loaded in state
Then as the story is edited, it (correctly) stores those changes using int based IDs
And that's where things get very broken.
This PR makes two small changes to
load_json
:action_id
so we don't have to cast it 4+ timesprocess_variable_changes
I could work around this on the frontend, but I think it makes more sense to have consistent types being sent over the socket