Fix core warnings #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoboticsYY
force-pushed
the
fix_core_warnings
branch
from
8692e3d
to
05b6f06
Compare
RoboticsYY
force-pushed
the
fix_core_warnings
branch
from
05b6f06
to
9491916
Compare
RoboticsYY
force-pushed
the
fix_core_warnings
branch
from
9491916
to
792e757
Compare
henningkayser
pushed a commit
that referenced
this pull request
Aug 27, 2020
backport fixes, some cleanup clang format fixes more cleanup + clang format #2
henningkayser
pushed a commit
that referenced
this pull request
Aug 27, 2020
clang format fixes #2 cmake style fixes, clang warning fixes revert clang warning fixes rebase fixes
henningkayser
pushed a commit
that referenced
this pull request
Aug 28, 2020
backport fixes, some cleanup clang format fixes more cleanup + clang format #2
henningkayser
pushed a commit
that referenced
this pull request
Aug 28, 2020
clang format fixes #2 cmake style fixes, clang warning fixes revert clang warning fixes rebase fixes
henningkayser
added a commit
that referenced
this pull request
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to remove the warnings of move_core appeared in the CI result of moveit2 PR#119.
The warning
-Wcast-qualcomes from tf2 and it is included at many places, so I temporally disabled this check in compiler options, and filed a PR to geometry2 PR#193.