Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Write a Message" pane gets stuck open #65

Closed
jfrederickson opened this issue Jul 12, 2016 · 3 comments
Closed

"Write a Message" pane gets stuck open #65

jfrederickson opened this issue Jul 12, 2016 · 3 comments
Assignees
Labels

Comments

@jfrederickson
Copy link

I just had this happen after clicking on my two buddy entries a few times:

screen shot 2016-07-12 at 1 07 14 pm

@jfrederickson
Copy link
Author

Looks like this happens when rapidly clicking on a buddy in the list.

@greg-js
Copy link
Contributor

greg-js commented Jul 13, 2016

Confirmed.

I did a little testing, and it seems to happen when the animation for bringing up the opener in lines 48-55 of ./app/components/keychain/KeyChainComposerOpener.js has not yet completed by the time the user deselects the last selected buddy.

If the animation duration is set to 1, the problem disappears, but obviously then the animation disappears too. I couldn't immediately find the code that removes the opener when no buddies are selected, but I'm guessing it should be a relatively easy fix once one does. I might look into it later tonight if no one else has by then.

@greg-js
Copy link
Contributor

greg-js commented Jul 14, 2016

Just submitted PR #66 with a fix (just to let you know since the reference isn't popping up here)

@heysanil heysanil added the bug label Aug 4, 2016
@heysanil heysanil self-assigned this Aug 4, 2016
@heysanil heysanil added this to the Generate Release milestone Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants