Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lengths of ticks/labels #23

Merged
merged 2 commits into from
Dec 5, 2021
Merged

fix lengths of ticks/labels #23

merged 2 commits into from
Dec 5, 2021

Conversation

nllong
Copy link
Member

@nllong nllong commented Dec 2, 2021

No description provided.

@ThibaultMarzullo
Copy link
Contributor

I suggest changing lines 94 and 95 to:

xticks = range(0, int(mp.length) + 6 * 3600, int(6 * 3600))
xlabels = range(0, int(mp.length/3600) + 6, 6)

Now, the ticks have the correct length (which strangely did not raise an error on my end) and the 24-hour tick also appears. It stopped at 18 before.

Copy link
Contributor

@ThibaultMarzullo ThibaultMarzullo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment proposes a solution for getting rid of the error and also showing the correct ticks.

@nllong
Copy link
Member Author

nllong commented Dec 3, 2021

This comment proposes a solution for getting rid of the error and also showing the correct ticks.

good point, look better @ThibaultMarzullo ?

Copy link
Contributor

@ThibaultMarzullo ThibaultMarzullo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nllong nllong merged commit 4a04153 into actb Dec 5, 2021
@nllong nllong deleted the actb-fix-mpc-plot branch December 5, 2021 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants