close gzip writer before uploading volumesnapshots file

skriss · skriss · commit 35bb533c2d0f · 2018-10-17T13:39:50.000-06:00
Signed-off-by: Steve Kriss &lt;steve@heptio.com&gt;
diff --git a/pkg/controller/backup_controller.go b/pkg/controller/backup_controller.go
@@ -440,6 +440,9 @@ func persistBackup(backup *pkgbackup.Request, backupContents, backupLog *os.File
 	if err := json.NewEncoder(gzw).Encode(backup.VolumeSnapshots); err != nil {
 		errs = append(errs, errors.Wrap(err, "error encoding list of volume snapshots"))
 	}
+	if err := gzw.Close(); err != nil {
+		errs = append(errs, errors.Wrap(err, "error closing gzip writer"))
+	}
 
 	if len(errs) > 0 {
 		// Don't upload the JSON files or backup tarball if encoding to json fails.

Original file line number	Diff line number	Diff line change
`@@ -440,6 +440,9 @@ func persistBackup(backup pkgbackup.Request, backupContents, backupLog os.File`
`440`	`440`	`if err := json.NewEncoder(gzw).Encode(backup.VolumeSnapshots); err != nil {`
`441`	`441`	`errs = append(errs, errors.Wrap(err, "error encoding list of volume snapshots"))`
`442`	`442`	`}`
	`443`	`+ if err := gzw.Close(); err != nil {`
	`444`	`+ errs = append(errs, errors.Wrap(err, "error closing gzip writer"))`
	`445`	`+ }`
`443`	`446`
`444`	`447`	`if len(errs) > 0 {`
`445`	`448`	`// Don't upload the JSON files or backup tarball if encoding to json fails.`