Feat: Herbarium - Use it to create mutations, queries and types #54

PedroMarquesFr · 2022-06-14T16:30:31Z

Created herbarium support to herbs2gql

Fixes #38

Proposed Changes

Created a new import called herbarium2gql file
Added herbarium library
New test
New documentation

Readiness Checklist

Author/Contributor

If documentation is needed for this change, has that been included in this pull request
Remember to check if code coverage decrease, if so, please implement the necessary tests

Reviewing Maintainer

Label as breaking if this is a large fundamental change
Label as either automation, bug, documentation, enhancement, infrastructure, or performance

italojs · 2022-06-15T13:47:48Z

test/support/herbarium/genericHerbariumObject.js

+    request: {
+      arrayField: [CoolEntity],
+    },
+


remove this blank line, please

italojs · 2022-06-15T13:47:55Z

test/support/herbarium/genericHerbariumObject.js

+    request: {
+      id: Number,
+    },
+


italojs · 2022-06-15T13:49:21Z

awesome PR @PedroMarquesFr , thank you very much!
could you add a session in our documentation please?

codecov · 2022-06-17T17:14:00Z

Codecov Report

Merging #54 (9cf5cc5) into master (4f6e74e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        14    +1     
  Lines          173       192   +19     
=========================================
+ Hits           173       192   +19

Impacted Files	Coverage Δ
src/herbs2gql.js	`100.00% <ø> (ø)`
src/herbarium2gql.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83b167b...9cf5cc5. Read the comment docs.

dalssoft · 2022-06-17T19:13:48Z

README.md

@@ -149,6 +149,16 @@ const [gql, resolver] = usecase2mutation(usecase, resolverFunc)
 ```

 Or you can use `herbs2gql` [`defaultResolver`](https://github.com/herbsjs/herbs2gql/blob/master/src/defaultResolver.js) implementation as a reference. 
+
+### Herbarium integration


Herbarium integration

Since this kind of integration will be the primary way of converting Herbs to GraphQL, this should be the first method to show, not the last

make sense, fixed

dalssoft · 2022-06-17T19:18:21Z

src/herbs2gql.js

@@ -7,4 +7,5 @@ module.exports = {
    defaultResolver: require('./defaultResolver'),
    defaultErrorHandler: require('./defaultErrorHandler').defaultErrorHandler,
    args2request: require('./args2request'),
+    herbarium2gql:require('./herbarium2gql')


herbarium2gql -> herbs2gql

The idea is that Herbarium is not the important part here, it is just part of Herbs

dalssoft · 2022-06-17T19:19:28Z

@PedroMarquesFr thank you for this PR. It is on the right path!

dalssoft · 2022-06-22T20:37:14Z

package.json

@@ -34,6 +34,7 @@
  "license": "MIT",
  "homepage": "https://github.com/herbsjs/herbs2gql#readme",
  "dependencies": {
+    "@herbsjs/herbarium": "^1.4.0",


shouldn't be put on "peerDependencies"?

true I didn't noticed

dalssoft · 2022-06-22T20:44:43Z

when I look at the To Do List project, there it is possible to find custom mutations and queries - here

in this format with herbarium, how would this scenario of custom mutations and queries look like?

PedroMarquesFr · 2022-06-25T01:20:41Z

when I look at the To Do List project, there it is possible to find custom mutations and queries - here

in this format with herbarium, how would this scenario of custom mutations and queries look like?

As mutations, queries and types array struture didnt change it would work the same way, using push method, but all in the index file and not on each individual file. Example using quoted To Do List project:

PedroMarquesFr · 2022-06-27T17:54:32Z

I think now the CI is working, can you run it again please @jhomarolo ?

test/support/herbarium/genericHerbariumObject.js

dalssoft · 2022-06-29T13:59:07Z

@PedroMarquesFr the PR is read to merge but it seems the test coverage has dropped. Can you check it?

jhomarolo-vortx · 2022-06-29T17:38:16Z

It seems that have some "it.only" inside the test suite. @PedroMarquesFr could you please remove them?

herbsjs-robot · 2022-06-29T21:50:04Z

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

PedroMarquesFr and others added 5 commits June 11, 2022 21:49

~~

a9e2b23

feat: created initial structure

82af7ab

fix: changed file name

0fa7003

feat: added new feature to readme and changed herbarium integration name

c5dc37d

feat: tests and improved herbarium2gql

e18324f

PedroMarquesFr mentioned this pull request Jun 14, 2022

Herbarium - Use it to create mutations, queries and types #38

Closed

fix: tests

7e41ea6

italojs requested changes Jun 15, 2022

View reviewed changes

fix: removed empty spaces

e2df351

PedroMarquesFr mentioned this pull request Jun 17, 2022

feat: new herbarium integration documentation herbsjs/herbsjs.github.io#132

Merged

4 tasks

jhomarolo requested a review from dalssoft June 17, 2022 17:11

fix: lint

0b3e761

dalssoft requested changes Jun 17, 2022

View reviewed changes

PedroMarquesFr added 2 commits June 19, 2022 21:55

fix: cr

cc08b8e

fix: tests

a23473f

dalssoft requested changes Jun 22, 2022

View reviewed changes

PedroMarquesFr added 2 commits June 24, 2022 22:42

fix: changed herbarium dependency to peerDependencies

25f7ac3

fix: ci

33036b2

dalssoft mentioned this pull request Jun 27, 2022

Herbarium with GraphQL herbsjs/herbsjs.github.io#135

Closed

dalssoft requested changes Jun 27, 2022

View reviewed changes

test/support/herbarium/genericHerbariumObject.js Show resolved Hide resolved

refacted: tests

22da16e

dalssoft approved these changes Jun 29, 2022

View reviewed changes

fix: removed only from test

9cf5cc5

dalssoft merged commit 92d38ce into herbsjs:master Jun 29, 2022

herbsjs-robot added the released Already in production label Jun 29, 2022

dalssoft mentioned this pull request Jul 19, 2022

Herbs2GQL with Herbarium - Update code generation herbsjs/herbs-cli#124

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Herbarium - Use it to create mutations, queries and types #54

Feat: Herbarium - Use it to create mutations, queries and types #54

PedroMarquesFr commented Jun 14, 2022 •

edited

Loading

italojs Jun 15, 2022

PedroMarquesFr Jun 17, 2022

italojs Jun 15, 2022

PedroMarquesFr Jun 17, 2022

italojs commented Jun 15, 2022

codecov bot commented Jun 17, 2022 •

edited

Loading

dalssoft Jun 17, 2022

PedroMarquesFr Jun 20, 2022

dalssoft Jun 17, 2022

PedroMarquesFr Jun 20, 2022

dalssoft commented Jun 17, 2022

dalssoft Jun 22, 2022

PedroMarquesFr Jun 25, 2022 •

edited

Loading

PedroMarquesFr Jun 25, 2022

dalssoft commented Jun 22, 2022

PedroMarquesFr commented Jun 25, 2022 •

edited

Loading

PedroMarquesFr commented Jun 27, 2022

dalssoft commented Jun 29, 2022

jhomarolo-vortx commented Jun 29, 2022

herbsjs-robot commented Jun 29, 2022

Feat: Herbarium - Use it to create mutations, queries and types #54

Feat: Herbarium - Use it to create mutations, queries and types #54

Conversation

PedroMarquesFr commented Jun 14, 2022 • edited Loading

Proposed Changes

Readiness Checklist

Author/Contributor

Reviewing Maintainer

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

italojs commented Jun 15, 2022

codecov bot commented Jun 17, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dalssoft commented Jun 17, 2022

Choose a reason for hiding this comment

PedroMarquesFr Jun 25, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dalssoft commented Jun 22, 2022

PedroMarquesFr commented Jun 25, 2022 • edited Loading

PedroMarquesFr commented Jun 27, 2022

dalssoft commented Jun 29, 2022

jhomarolo-vortx commented Jun 29, 2022

herbsjs-robot commented Jun 29, 2022

PedroMarquesFr commented Jun 14, 2022 •

edited

Loading

codecov bot commented Jun 17, 2022 •

edited

Loading

PedroMarquesFr Jun 25, 2022 •

edited

Loading

PedroMarquesFr commented Jun 25, 2022 •

edited

Loading