Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Softfloat public headers require C99 standard headers, leading to Hercules build failures on older VS versions. #2

Closed
srorso opened this issue Dec 22, 2016 · 2 comments
Assignees
Labels

Comments

@srorso
Copy link
Contributor

srorso commented Dec 22, 2016

Public header softfloat.h requires stdint.h and stdbool.h, which are C99 headers not available with older versions of Visual Studio.

SoftFloat 3a For Hercules (S3FH) builds correctly because the CMake process for S3FH substitutes its own versions of the required C99 headers when they are not available on the host system. But those substitute versions are not available to the Hercules build, which includes the softfloat.h public header, so the build fails.

@srorso
Copy link
Contributor Author

srorso commented Dec 22, 2016

See also Hercules 4.0 Issue #172.

srorso added a commit that referenced this issue Dec 22, 2016
Addresses issue #2.  Install C99 headers in S3FH include directory when they are not present on the host system.  Change substitute stdint.h to compile correctly on Windows.
@srorso
Copy link
Contributor Author

srorso commented Feb 8, 2018

Issue addressed in commit d7d1229. That commit refactored header #includes and added type definitions if needed on pre-C99 systems without conflicting with those in Hercules-390 Hyperion.

@srorso srorso closed this as completed Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant