nis entries in /etc/shadow #237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the nis default entry + and the nis default entry with overrides +::::::::
| . [ label "inactive_days" . store integer? . colon ] | ||
| . [ label "expire_date" . store integer? . colon ] | ||
| . [ label "flag" . store integer? ] in | ||
| [ dels "+" . label "@nisdefault" . overrides? . eol ] |
There was a problem hiding this comment.
Lines 65-72 can probably be put in common with the entry definition here.
|
Thanks for the PR. Can you just factorize the code as stated in my comment please? |
Refactored to account for common lines per PR comment Added put tests for @nisdefault
|
Thanks. Updated per comment. |
lutter
pushed a commit
that referenced
this pull request
May 22, 2015
Add support for the NIS default entry + and the nis default entry with overrides +:::::::: Based on #237
|
Squashed into one commit, edited commit message slightly and commited as 071175d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the nis default entry + and the nis default entry with overrides +:::::::: in /etc/shadow