Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asl-typing-step5 #885

Merged
merged 4 commits into from
Jul 25, 2024
Merged

asl-typing-step5 #885

merged 4 commits into from
Jul 25, 2024

Conversation

Roman-Manevich
Copy link
Collaborator

@Roman-Manevich Roman-Manevich commented Jun 26, 2024 •
edited
Loading

  • Typing of Global Declarations
  • Static Evaluation
  • Symbolic Equivalence Testing

@Roman-Manevich Roman-Manevich force-pushed the asl-typing-step5 branch 3 times, most recently from 1fbd2fc to 785feb9 Compare July 16, 2024 06:05
jalglave
jalglave reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@jalglave jalglave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Roman here are a few comments.
Jade

asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
@Roman-Manevich Roman-Manevich force-pushed the asl-typing-step5 branch 3 times, most recently from 8e4fc2b to 2b1080e Compare July 25, 2024 08:04
jalglave
jalglave reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@jalglave jalglave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Roman, here are a few comments

asllib/doc/ASLFormal.tex Outdated Show resolved Hide resolved
asllib/doc/ASLSemanticsReference.tex Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
jalglave
jalglave reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@jalglave jalglave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Roman, here are some more comments

asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
asllib/doc/ASLTypingReference.tex Outdated Show resolved Hide resolved
@jalglave
Copy link
Member

thanks Roman, go ahead when you want.

@Roman-Manevich Roman-Manevich marked this pull request as ready for review July 25, 2024 13:16
@Roman-Manevich Roman-Manevich merged commit 7be6abe into master Jul 25, 2024
3 checks passed
@Roman-Manevich Roman-Manevich deleted the asl-typing-step5 branch August 10, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalglave jalglave jalglave left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Roman-Manevich @jalglave