[Asl] Explode constant intervals before multiplication #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadrienRenaud
force-pushed
the
asl-explode-intervals
branch
2 times, most recently
from
e94cd18
to
9ecd586
Compare
HadrienRenaud
commented
Jul 9, 2024
HadrienRenaud
commented
Jul 9, 2024
HadrienRenaud
commented
Jul 9, 2024
HadrienRenaud
force-pushed
the
asl-explode-intervals
branch
4 times, most recently
from
b9f34b0
to
479145c
Compare
HadrienRenaud
force-pushed
the
asl-explode-intervals
branch
from
479145c
to
d854456
Compare
HadrienRenaud
force-pushed
the
asl-explode-intervals
branch
from
d854456
to
9711b23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a transformation of intervals into sets before doing a multiplication in order not to lose any precision on those. This can only be done for constant sets and up to a certain point, here the maximum set size for which this is done is
1 lsl 31, or a bit more than 1 billion.