Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The choice operator of the "concurrent" ASL interpreted now assigns unresolved condition to TRUE or FALSE depending on the selected branch.
As a result the "SomeBoolean" primitive can now reduce to a simple non-resolved variable and could have been replaced by the construct
UNKNOWN : boolean
. Typically the following running herd7 on the following test will result in two outcomes with values0
and1
forx
. Moreover the final values ofb
areFALSE
andTRUE
, respectively.Previously, the same result could be achieved by adding option
-variant ASL
or by replacing theUNKNOWN
expression by a primitive callSomeBoolean ()
.Unfortunately this "complete" resolution does not succeed in general. See the example
herd/tests/instructions/ASL/unknown-integer.litmus
for instance.