Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When closing ExternalVector return a view to its data. #62

Closed
boxdot opened this issue Aug 16, 2018 · 1 comment
Closed

When closing ExternalVector return a view to its data. #62

boxdot opened this issue Aug 16, 2018 · 1 comment

Comments

@boxdot
Copy link
Collaborator

boxdot commented Aug 16, 2018

ExtenalVector does not provide indexed access to its data since it may not be yet written to disk. However, after the vector is closed, its data is fully written and constant from that point in time. Often, one wants to access the data after it was closed. So, it would make sense on closing to return an ArrayView to its data for convenience.

What do you think, @imagovrn, @VeaaC?
CC: @eikesr.

@VeaaC
Copy link
Collaborator

VeaaC commented Aug 20, 2018

Agree fully: I would propose to return an ArrayView after closing the vector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants