virtq: various simplifications #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cagatay-y
force-pushed
the
too-virtq-too-refactor
branch
from
d5073df
to
bf6a373
Compare
cagatay-y
force-pushed
the
too-virtq-too-refactor
branch
7 times, most recently
from
46176b1
to
8deffb1
Compare
cagatay-y
force-pushed
the
too-virtq-too-refactor
branch
from
8deffb1
to
eec251b
Compare
mkroening
requested changes
Jun 24, 2024
The specification only prescribes memory barriers before the setting of the flags, which is taken care of by `make_available_with_state`.
`ctrl_desc` do not belong to the individual buffers but to the whole transfer. Moving it to the TransferToken structure allows us to avoid aliasing.
Now that every variant has the same fields, Buffer can be a simple struct instead of an enum. The directness is specified in the TransferToken and whether the Buffer is for a single element or chained elements is deduced from the number of elements in the desc_lst.
There does not seem to be anything in the spec that requires the Buffer IDs for the packed queue to be larger than 0. For split queues, indices are already reduced by one for operations that deal with `MemDescrId`s.
Not every MemDescr necessarily has its own id in the queue. For example, descriptors that make up a chain in a packed queue share their Buffer ID. Descriptors in an indirect table have ids but they don't take them from their queue's pool. Not making the id a field of the MemDescr also removes the coupling between the MemDescr and a queue.
cagatay-y
force-pushed
the
too-virtq-too-refactor
branch
from
1a36457
to
e81458e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.