Restore network configuration via kernel cli #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkroening
requested changes
Nov 9, 2022
There was a problem hiding this comment.
Thanks for your PR! :)
It would be good to introduce an fn var(key: &str) -> Option<String> in env akin to std::env::var.
The variables could then be defined with macros and with less redundancy, similar to how it was before eb2a46f.
If you would rather have me do these changes, just say so.
Also, please squash your commits in the end. :)
|
I agree that would make sense, I will try to implement that :) |
JTS22
force-pushed
the
network-cli
branch
5 times, most recently
from
8ed7bcc
to
1560ee6
Compare
mkroening
requested changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores the ability to set the network IP address, gateway and subnet mask via the kernel commandline arguments
-ip,-gatewayand-mask.Closes #522