add BSD socket layer #633
Merged
add BSD socket layer #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkroening A network interrupt has to wakeup all async tasks to check their tasks. Currently, I use a BtreeMap to store all blocked async tasks. The interrupts clears the map and wakeup all tasks. Do you have an better idea? |
to realize a BSD socket layer, the executor has to return dirctly UNIX-like error number because the layer depends on a C interface and doesn't support Rust's error handling
becaue we didn't know, which task is waiting for the network interface
- move __sys_recv to the module socket
the implementation is derived from https://github.com/cmnord/pflock/tree/cnord/loom
RX packet are directly copied from the network interfaces to temporary vector. The ring buffers from the network interface must be cleared as soon as possible.
- stay in polling mode - trigger a periodic timer to check, if the NIC is used - if not, the polling mode will be disabled
- disable polling mode only if all tasks want to leave the polling mode
mkroening
approved these changes
Jan 22, 2023
|
bors try |
tryBuild succeeded: |
bors bot
added a commit
to hermit-os/hermit-rs
that referenced
this pull request
Jan 25, 2023
388: add BSD socket layer r=stlankes a=stlankes The new BSD socket layer depends on hermit-os/kernel#633 and a revised version of `std`. `std` is part of the [rust](/hermitcore/rust/tree/socket) fork. Note: If you use this version, please modify `Cargo.toml`. [`hermit-abi`](https://github.com/hermitcore/rust/blob/socket/library/std/Cargo.toml#L45) must point to the version of this PR. Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
bors bot
added a commit
to hermit-os/hermit-rs
that referenced
this pull request
Jan 25, 2023
388: add BSD socket layer r=stlankes a=stlankes The new BSD socket layer depends on hermit-os/kernel#633 and a revised version of `std`. `std` is part of the [rust](/hermitcore/rust/tree/socket) fork. Note: If you use this version, please modify `Cargo.toml`. [`hermit-abi`](https://github.com/hermitcore/rust/blob/socket/library/std/Cargo.toml#L45) must point to the version of this PR. Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR realize a classical BSD socket layer. To realize a BSD socket layer, the executor has to return directly UNIX-like error number because the layer depends on a C interface and doesn't support Rust's error handling.