Add alloc support #278
Merged
Add alloc support #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mkroening
requested changes
Nov 30, 2023
mkroening
requested changes
Jan 10, 2024
There was a problem hiding this comment.
Thanks a lot!
Code-wise, this looks excellent. Just a few more requests on the form:
- The
Cargo.lockfile should not be added to.gitignore. Instead, it should track the minimum changes necessary by this PR. - This PR should not include any merge commits. In this case, we might even squash everything into one commit.
- The formatting CI check fails (run
cargo fmt) to fix any formatting issues.
If you need help with rebasing, reach out. :)
duanyu-yu
force-pushed
the
alloc
branch
4 times, most recently
from
328e86e
to
a31d514
Compare
mkroening
requested changes
Jan 11, 2024
There was a problem hiding this comment.
Ah, CI shows that this does not work on UEFI, which makes sense, since UEFI already provides a global allocator.
Let's move the dependencies in Cargo.toml to [target.'cfg(target_os = "none")'.dependencies] and mark mod allocator; with #[cfg(target_os = "none")]. We could move the declaration of the global allocator into the allocator module, too.
Removed nightly features; Simplified allocator Fixed formatting issues Move the global allocator into the allocator module
mkroening
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added alloc support for loader, based on the previous bootstrap and bump allocator implementations from the kernel.