-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(x86_64): handle processor frequency not present in CPUID #688
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
- Coverage 68.05% 67.99% -0.06%
==========================================
Files 20 20
Lines 2310 2312 +2
==========================================
Hits 1572 1572
- Misses 738 740 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! :)
What environment are you experiencing this in? Are you running on AMD where this may not be working according to the docs?
What happens on your system with this patch? Are you getting an "Unable to determine processor frequency" warning or is detect_freq_from_cpuid_hypervisor_info
successful?
In the future, it might make sense to explore using sysinfo
for this, which should be much more reliable: #690
Edit: Ah, this is for #537, right?
Co-authored-by: Martin Kröning <mkroening@posteo.net>
@charlottestinson, @MrMunoz, are you planning to continue pursuing this PR? :) |
Superseded in #701. |
Fixed unenumerated tinfo.numerator() causing panic.
Closes #537