Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x86_64): handle processor frequency not present in CPUID #688

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

charlottestinson
Copy link
Contributor

@charlottestinson charlottestinson commented May 6, 2024

Fixed unenumerated tinfo.numerator() causing panic.

Closes #537

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.99%. Comparing base (2825277) to head (7afebf4).

Files Patch % Lines
src/arch/x86_64/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
- Coverage   68.05%   67.99%   -0.06%     
==========================================
  Files          20       20              
  Lines        2310     2312       +2     
==========================================
  Hits         1572     1572              
- Misses        738      740       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/arch/x86_64/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! :)

What environment are you experiencing this in? Are you running on AMD where this may not be working according to the docs?

What happens on your system with this patch? Are you getting an "Unable to determine processor frequency" warning or is detect_freq_from_cpuid_hypervisor_info successful?

In the future, it might make sense to explore using sysinfo for this, which should be much more reliable: #690

Edit: Ah, this is for #537, right?

@mkroening mkroening self-assigned this May 7, 2024
MrMunoz and others added 2 commits May 8, 2024 17:02
Co-authored-by: Martin Kröning <mkroening@posteo.net>
@mkroening mkroening changed the title Cpu frequency fix(x86_64): handle processor frequency not present in CPUID May 18, 2024
@mkroening
Copy link
Member

@charlottestinson, @MrMunoz, are you planning to continue pursuing this PR? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running uhyve in a Linux VirtualBox VM (with nested virtualization enabled) panics in detect_freq_from_cpuid
3 participants