Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x86_64): don't panic on unknown port #691

Merged
merged 1 commit into from
May 7, 2024
Merged

fix(x86_64): don't panic on unknown port #691

merged 1 commit into from
May 7, 2024

Conversation

mkroening
Copy link
Member

QEMU and Firecracker don't panic here either.

With this, hermit::arch::x86_64::shutdown from hermit-os/kernel#1181 would also work on Uhyve, though proper exits via system calls still go through the exit hypercall.

Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
@jounathaen
Copy link
Member

LGTM!

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 68.05%. Comparing base (3e6edc2) to head (de6956d).

Files Patch % Lines
src/linux/x86_64/kvm_cpu.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
- Coverage   68.11%   68.05%   -0.06%     
==========================================
  Files          20       20              
  Lines        2308     2310       +2     
==========================================
  Hits         1572     1572              
- Misses        736      738       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkroening mkroening added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 2825277 May 7, 2024
10 checks passed
@mkroening mkroening deleted the calm-port branch May 7, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants