Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App responsive container #461

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Conversation

AjayiMike
Copy link
Contributor

This PR addresses the issue of the uncontrolled width and layout of the application, which is perticularly noticeable on large screens

Preview of the fix: https://www.loom.com/share/e9ff06ee8c804ab38f314657957e8428?sid=2b81abc0-7da7-4ab1-b923-46ccae86de08

closes #452

@AjayiMike AjayiMike requested a review from hellno as a code owner August 10, 2024 02:29
Copy link

vercel bot commented Aug 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
herocast ✅ Ready (Inspect) Visit Preview Aug 12, 2024 11:51am

@hellno
Copy link
Collaborator

hellno commented Aug 12, 2024

thanks for the PR. the loom looks great 🙌🏼

if you activate the formatting or linting for the project (I think it's four spaces), there will be a lot less changes and everything will be aligned with the rest of the project :)

@AjayiMike
Copy link
Contributor Author

Okay, I will format the codebase and update the PR

@AjayiMike
Copy link
Contributor Author

AjayiMike commented Aug 12, 2024

I just did. I'll open an issue to address the need to manually format the files and prevent future occurence.

@hellno
Copy link
Collaborator

hellno commented Aug 12, 2024

looks great, thank you! 🙌🏼

@hellno hellno merged commit b811df0 into hero-org:main Aug 12, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The application is taking up the entire screen width, no matter how large it is
2 participants