Improved error handling for http requests #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treat outside the 200-299 range as errors Parse response Set response error
britzl
commented
Feb 19, 2021
| log(result.response) | ||
| result.response = json.decode(result.response) | ||
| log(result.response) | ||
| local ok, decoded = pcall(json.decode, result.response) |
There was a problem hiding this comment.
Always try to decode the response (but catch errors)
britzl
commented
Feb 19, 2021
| log(result.response) | ||
| local ok, decoded = pcall(json.decode, result.response) | ||
| if not ok then | ||
| result.response = { error = true, message = "Unable to decode response" } |
There was a problem hiding this comment.
The response was not JSON (or it was malformed). Is it safe to assume that it is an error in this case?
There was a problem hiding this comment.
Yes, it's safe to assume. If there's a bug which will fail the request it could cause a load balancer to return a HTML error response.
britzl
commented
Feb 19, 2021
| if not ok then | ||
| result.response = { error = true, message = "Unable to decode response" } | ||
| elseif result.status < 200 or result.status > 299 then | ||
| result.response = { error = decoded.error or true, message = decoded.message, code = decoded.code } |
There was a problem hiding this comment.
Anything outside the 200-299 range is treated as an error
|
Looks good to me @britzl Thanks 🙏 |
novabyte
approved these changes
Feb 23, 2021
|
Thanks. Want me to create a new release @novabyte ? |
|
That would be great @britzl 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23