limited scope of of retry logic to very specific 500-level codes from… #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomglenn
reviewed
Nov 20, 2023
| } | ||
| } | ||
|
|
||
| return false; |
There was a problem hiding this comment.
Are we intentionally removing -1 from the list of monitored exception status codes here?
Also, I would tend to agree that we probably don't want to retry on an Internal Server Error as it's likely that more often than not the same error will occur if nothing about the request has changed.
There was a problem hiding this comment.
Yes that's intentional. Originally I think I spoke with @novabyte about checking for that value if we don't receive a reply from the load balancer, but looking at the client code, the client timeout won't create an ApiResponseException.
tomglenn
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the server
The criteria under which we retry is currently too broad.
@zyro I am not sure that we want the client to automatically retry on receiving 500 (Internal Error) from Nakama. Looking through Nakama, it could certainly be a temporary database issue, but it looks like it could be more permanent issues as well. What do you think about not including 500 in the retry criteria?