Removes Yarn in favour of NPM. Updates nakama-js, nakama-js-prototbuf… #143
Conversation
… and satori-js build scripts and dependencies. Updates documentation to include satori-js.
|
@lugehorsam This PR doesn't currently change My proposal would be to re-implement the test suite on modern Node (v18) and packages as a separate PR. Justification for getting this change in sooner (before test suite is redone) is to make the release of |
|
@tomglenn I'm all for doing it in steps |
|
Cool, marked as ready. As discussed we'll go for an iterative approach. This PR gets us the main packages upgraded and switched over to |
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| import esbuild from 'esbuild'; |
There was a problem hiding this comment.
what is the .mjs extension?
There was a problem hiding this comment.
It's an es6 module file. Recommended way of writing esbuild build scripts - https://esbuild.github.io/getting-started/#build-scripts
| "whatwg-fetch": "^2.0.3" | ||
| }, | ||
| "devDependencies": { | ||
| "@babel/runtime": "^7.12.5", |
There was a problem hiding this comment.
Should these be removed for Satori? I think we still want to target all the same platforms including cocos creator.
There was a problem hiding this comment.
I was also wondering about the other types of Javascript modules we publish (cjs, iife, umd) and if those should be applied to Satori as well.
There was a problem hiding this comment.
whatwg-fetch should go back in yes (as well as js-base64 and base64-arraybuffer, good catch.)
babel isn't needed as esbuild handles transpiling.
Yep satori-js builds all the appropriate js module formats (specifically cjs, esm, iife and umd). I do need to add the rollup -c --bundleAsCjs back into the build script though.
… and satori-js build scripts and dependencies. Updates documentation to include satori-js.