use Last() implementation when calculating tournament deadlines #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 29, 2023 10:55
lugehorsam
commented
Sep 12, 2023
|
I added a test for an additional case I thought of but this is still good to review. |
sesposito
requested changes
Sep 18, 2023
There was a problem hiding this comment.
Changes are also required to https://github.com/heroiclabs/nakama/blob/master/server/core_leaderboard.go#L728
|
Ready for re-review. |
|
Will still need a 👍 from @sesposito if it deserves it to unblock the merge |
sesposito
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports gorhill/cronexpr#28 to our internal version of
cronexpr. This gives us theLast()method which allows us to infer the start time directly from the cronexpr rather than estimating it by invokingNext()twice.