Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StorageReadObjects function optimization #1145

Closed
wants to merge 1 commit into from
Closed

StorageReadObjects function optimization #1145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions server/core_storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,9 +416,9 @@ func storageListObjects(rows *sql.Rows, limit int) (*api.StorageObjectList, erro
}

func StorageReadObjects(ctx context.Context, logger *zap.Logger, db *sql.DB, caller uuid.UUID, objectIDs []*api.ReadStorageObjectId) (*api.StorageObjects, error) {
collectionParam := make([]string, 0, len(objectIDs))
keyParam := make([]string, 0, len(objectIDs))
userIdParam := make([]uuid.UUID, 0, len(objectIDs))
collectionParam := make([]string, len(objectIDs))
keyParam := make([]string, len(objectIDs))
userIdParam := make([]uuid.UUID, len(objectIDs))

// When selecting variable number of object we'd like to keep number of
// SQL query arguments constant, otherwise query statistics explode, because
Expand Down Expand Up @@ -451,9 +451,9 @@ func StorageReadObjects(ctx context.Context, logger *zap.Logger, db *sql.DB, cal
`
}

for _, id := range objectIDs {
collectionParam = append(collectionParam, id.Collection)
keyParam = append(keyParam, id.Key)
for index, id := range objectIDs {
collectionParam[index] = id.Collection
keyParam[index] = id.Key
var reqUid uuid.UUID
if uid := id.GetUserId(); uid != "" {
if uid, err := uuid.FromString(uid); err == nil {
Expand All @@ -463,7 +463,7 @@ func StorageReadObjects(ctx context.Context, logger *zap.Logger, db *sql.DB, cal
return nil, err
}
}
userIdParam = append(userIdParam, reqUid)
userIdParam[index] = reqUid
}

params := []interface{}{collectionParam, keyParam, userIdParam}
Expand Down