Fix ptr slices assertions in js nk module arguments #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goja introduced the following change: dop251/goja@7749907 JS arrays backed by a Go slice referenced by a pointer would be returned by .Export() as []S, but now are returned as *[]S which requires changing all the type assertions when dealing with these values.
ftkg
approved these changes
Dec 5, 2023
syhpoon
reviewed
Dec 6, 2023
| panic(r.NewTypeError("Invalid argument - user ids must be an array.")) | ||
| userIDsIn := f.Argument(2) | ||
| if userIDsIn != goja.Undefined() && userIDsIn != goja.Null() { | ||
| userIDs, err = exportToSlice[[]string](userIDsIn) |
There was a problem hiding this comment.
a very minor suggestion but it might be worthwhile to panic inside the exportToSlice and avoid error checks in all these multiple places. Providing, of, course it's supposed to panic in every case when invoking this func.
There was a problem hiding this comment.
I had considered it but then thought it would be best to keep both the panics more explicit and the custom error messages as they may be more meaningful to the user.
syhpoon
approved these changes
Dec 6, 2023
|
I added a commit as I had missed a few |
syhpoon
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goja introduced the following change:
dop251/goja@7749907 JS arrays backed by a Go slice referenced by a pointer would be returned by .Export() as []S, but now are returned as *[]S which requires changing all the type assertions when dealing with these values.