Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): update subdomain examples #2360

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

zwhitfield3
Copy link
Contributor

Why the change?

GUS Card

We are currently updating our future app subdomains to prevent potential attack vectors. While there are no technical changes required in the Heroku CLI for updating the subdomains for newly created apps, this PR does the following:

  • Updates subdomains copy in examples to maintain product consistency ✅

Additional Notes

  • N/A

How to verify?

  1. Get copy approval from @SandyPantsLai

@zwhitfield3 zwhitfield3 requested a review from a team as a code owner May 23, 2023 17:42
@zwhitfield3 zwhitfield3 changed the title chore(cli): update subdomain examples chore(cli): update subdomain examples - DO NOT MERGE YET! May 23, 2023
@zwhitfield3 zwhitfield3 changed the title chore(cli): update subdomain examples - DO NOT MERGE YET! chore(cli): update subdomain examples Jun 14, 2023
@zwhitfield3 zwhitfield3 temporarily deployed to AcceptanceTests June 14, 2023 16:30 — with GitHub Actions Inactive
@zwhitfield3 zwhitfield3 temporarily deployed to AcceptanceTests June 14, 2023 16:30 — with GitHub Actions Inactive
@zwhitfield3 zwhitfield3 temporarily deployed to AcceptanceTests June 14, 2023 16:30 — with GitHub Actions Inactive
@zwhitfield3 zwhitfield3 merged commit 8ca718c into main Jun 14, 2023
@zwhitfield3 zwhitfield3 deleted the zw/subdomain-example-update branch June 14, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants