Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'enabled' to list of accepted bool truthy values #6

Merged
merged 1 commit into from
Nov 4, 2016

Conversation

rhodrid
Copy link
Contributor

@rhodrid rhodrid commented Sep 13, 2016

The Heroku ruby-buildpack sets RAILS_LOG_TO_STDOUT and RAILS_SERVE_STATIC_FILES to 'enabled' if they are not present for apps using Rails 4.2 and upwards. This change adds 'enabled' to the list of accepted bool truthy values.

@rhodrid
Copy link
Contributor Author

rhodrid commented Nov 4, 2016

@jkakar any chance you could look at this PR. Thx

@jkakar
Copy link
Contributor

jkakar commented Nov 4, 2016

Oops, sorry for delay in reviewing this @rhodrid, for some reason I wasn't subscribed to updates. This looks great, thank you!

@jkakar jkakar merged commit e3205ca into heroku:master Nov 4, 2016
@jkakar
Copy link
Contributor

jkakar commented Nov 4, 2016

Also, I'll publish a new gem in the next few days.

@rhodrid
Copy link
Contributor Author

rhodrid commented Nov 30, 2016

@jkakar Great, and thanks for merging 👍

@jkakar
Copy link
Contributor

jkakar commented Nov 30, 2016

@rhodrid Sorry, I dropped the ball and forgot about this until I saw your comment just now. There's a new gem on Rubygems with your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants