Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop bzr dependency support #553

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Drop bzr dependency support #553

merged 2 commits into from
Apr 23, 2024

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented Apr 23, 2024

This PR removes support for downloading bzr-hosted dependencies directly.

Installing bzr-hosted dependencies via GOPROXY will work with default GOPROXY settings since go1.13.

Why this change?

  • heroku-24 does not include a bzr installation.
  • Since go1.13, GOPROXY='https://proxy.golang.org,direct' is the default value. This means that dependencies will be fetched from the proxy, which grants indirect bzr support.
  • I was unable to find any modern go packages that still use bzr as their primary installation source. Most everything uses github.com, go.dev, gopkg.in, or private git hosts now.

@joshwlewis joshwlewis marked this pull request as ready for review April 23, 2024 16:52
@joshwlewis joshwlewis requested a review from a team as a code owner April 23, 2024 16:52
@joshwlewis joshwlewis merged commit 18b1171 into main Apr 23, 2024
4 checks passed
@joshwlewis joshwlewis deleted the drop-bzr-support branch April 23, 2024 20:28
@heroku-linguist heroku-linguist bot mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants